Stop incrementing date when decrement hour is pressed (Min Date defined, hour format set to 12) #15423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
remove test consideration for written input fixed code tests prettier fix remove test
revert timedoc back to initial revert picklist test and reintroduce calendar test
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #15286
Solve for #15286
The timer should now loop back to valid times on min date once it has reached min.sethours(). For instance if the min set hour is 17 aka 5PM, when hour is decremented it should become 11PM ( this enhancement can be removed but thought it would improve accessibility by reducing the number of clicks required to reach desired valid time)
Additionally, I've added a check for valid date ( if min date and/or max date is present) when entering dates manually into the calendar input.