Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Table: Editing row with calendar component causes it to terminate editing #15555

Closed
wants to merge 5 commits into from
Closed

Table: Editing row with calendar component causes it to terminate editing #15555

wants to merge 5 commits into from

Conversation

RogueTea
Copy link
Contributor

@RogueTea RogueTea commented May 13, 2024 •
edited

Fixes #15498

@RogueTea
temp fix not working correctly
3d61df3
@RogueTea
Merge branch 'master' into edit-table-row-with-calendar
2d9c3f2
@RogueTea
appears to be working
9dfe1f9 
revert and remove tester files

resolve the issue of selecting all rows as editable

Update quill version
@vercel Vercel
Copy link

vercel bot commented May 13, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview May 15, 2024 8:29am

SoyDiego
SoyDiego reviewed May 13, 2024
View reviewed changes
src/app/components/table/table.ts Outdated
@@ -2415,18 +2420,21 @@ export class Table implements OnInit, AfterViewInit, AfterContentInit, Blockable
initRowEdit(rowData: any) {
let dataKeyValue = String(ObjectUtils.resolveFieldData(rowData, this.dataKey));
this.editingRowKeys[dataKeyValue] = true;
this.isRowEditiable = true;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo error isRowEditable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name changed

@cetincakiroglu cetincakiroglu added Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. Status: Pending Review Issue or pull request is being reviewed by Core Team labels May 14, 2024
@RogueTea
format
7e9a977 
WIP test

change variable name to be clearer

change var in tests
@RogueTea RogueTea force-pushed the edit-table-row-with-calendar branch from f7597a5 to 7e9a977 Compare May 14, 2024 15:55
@RogueTea
Copy link
Contributor Author

Wouldn't mind some help with the test. I'm struggling to get the calendar variable to change.

@cetincakiroglu
Copy link
Contributor

Hi,

Commented on the issue, closing the PR #15498

@cetincakiroglu cetincakiroglu removed Status: Pending Review Issue or pull request is being reviewed by Core Team Resolution: Needs Revision The pull request can't be merged. Conflicts need to be corrected or documentation and code updated. labels May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoyDiego SoyDiego SoyDiego left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Component: Table + Calendar: Row editing is closed when date is selected from calendar
3 participants
@RogueTea @cetincakiroglu @SoyDiego