Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): new component and example usage in menu #15644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

alexciesielski
Copy link
Contributor

@alexciesielski alexciesielski commented May 21, 2024

Feature Requests

As described in this discussion I want to use a different set of icons in the menu component, without having to override the whole item template.

I just went ahead and implemented the basics without waiting for confirmation, as it was such an easy thing to implement.

If accepted I can go ahead and add a documentation page for the Icon component and additionally refactor other components to make use of it, instead of directly using <i class ....>.

Copy link

vercel bot commented May 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
primeng ⬜️ Ignored (Inspect) Visit Preview May 21, 2024 3:08pm

@SoyDiego
Copy link
Contributor

Feature Requests

As described in this discussion I want to use a different set of icons in the menu component, without having to override the whole item template.

I just went ahead and implemented the basics without waiting for confirmation, as it was such an easy thing to implement.

If accepted I can go ahead and add a documentation page for the Icon component and additionally refactor other components to make use of it, instead of directly using <i class ....>.

Thanks for your contribution, could you add a stackblitz or screenshots to see your implementation?

Thanks!

@alexciesielski
Copy link
Contributor Author

Well, on the surface nothing changes. By default it is supposed to look exactly the same as it does right now.

It only looks different if you provide your own IconComponent.

Check out the unit test I wrote to see the usage.

Also feel free to ask questions if anything is unclear.

@cetincakiroglu cetincakiroglu added Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team labels May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Discussion Issue or pull request needs to be discussed by Core Team Status: Pending Review Issue or pull request is being reviewed by Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants