feat(icon): new component and example usage in menu #15644
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Requests
As described in this discussion I want to use a different set of icons in the
menu
component, without having to override the whole item template.I just went ahead and implemented the basics without waiting for confirmation, as it was such an easy thing to implement.
If accepted I can go ahead and add a documentation page for the
Icon
component and additionally refactor other components to make use of it, instead of directly using<i class ....>
.