Skip to content

Commit

Permalink
Refactor #2397
Browse files Browse the repository at this point in the history
  • Loading branch information
mertsincan committed Nov 6, 2021
1 parent a42c765 commit b036b6b
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 16 deletions.
9 changes: 1 addition & 8 deletions src/components/confirmpopup/ConfirmPopup.js
@@ -1,14 +1,7 @@
import React, { Component } from 'react';
import ReactDOM from 'react-dom';
import PropTypes from 'prop-types';
import {
DomHandler,
ObjectUtils,
classNames,
ZIndexUtils,
ConnectedOverlayScrollHandler,
IconUtils
} from '../utils/Utils';
import { DomHandler, ObjectUtils, classNames, ZIndexUtils, ConnectedOverlayScrollHandler, IconUtils } from '../utils/Utils';
import { Button } from '../button/Button';
import { CSSTransition } from '../csstransition/CSSTransition';
import { localeOption } from '../api/Api';
Expand Down
4 changes: 1 addition & 3 deletions src/components/utils/ClassNames.js
@@ -1,5 +1,3 @@
import React from 'react';

export function classNames(...args) {
if (args) {
let classes = [];
Expand All @@ -14,7 +12,7 @@ export function classNames(...args) {
if (type === 'string' || type === 'number') {
classes.push(className);
}
else if (type === 'object' && !React.isValidElement(className)) {
else if (type === 'object') {
const _classes = Array.isArray(className) ? className : Object.entries(className).map(([key, value]) => !!value ? key : null);

classes = _classes.length ? classes.concat(_classes.filter(c => !!c)) : classes;
Expand Down
6 changes: 4 additions & 2 deletions src/components/utils/IconUtils.js
Expand Up @@ -2,8 +2,10 @@ import * as React from "react";
import ObjectUtils from "./ObjectUtils";

export default class IconUtils {

static getJSXIcon(icon, iconProps, parentProps) {
let content = null;

if (icon) {
let iconType = typeof icon;
content = <span {...iconProps}></span>;
Expand All @@ -15,10 +17,10 @@ export default class IconUtils {
props: parentProps
};

content = <span {...iconProps}>{ObjectUtils.getJSXElement(icon, defaultContentOptions)}</span>;
return ObjectUtils.getJSXElement(icon, defaultContentOptions);
}

}

return content;
}
}
2 changes: 0 additions & 2 deletions src/components/utils/ObjectUtils.js
@@ -1,5 +1,3 @@
import * as React from 'react';

export default class ObjectUtils {

static equals(obj1, obj2, field) {
Expand Down
2 changes: 1 addition & 1 deletion src/components/utils/Utils.js
Expand Up @@ -8,4 +8,4 @@ import IconUtils from './IconUtils';
import UniqueComponentId from './UniqueComponentId';
import { ZIndexUtils } from './ZIndexUtils';

export { classNames, ConnectedOverlayScrollHandler, DomHandler, EventBus, FilterUtils, mask, ObjectUtils, IconUtils, UniqueComponentId, ZIndexUtils };
export { classNames, ConnectedOverlayScrollHandler, DomHandler, EventBus, mask, ObjectUtils, IconUtils, UniqueComponentId, ZIndexUtils };

0 comments on commit b036b6b

Please sign in to comment.