Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable cell editor only validates on enter #1024

Closed
NellyHaglund opened this issue Sep 30, 2019 · 2 comments
Closed

DataTable cell editor only validates on enter #1024

NellyHaglund opened this issue Sep 30, 2019 · 2 comments
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
7.0.0.Final

Comments

@NellyHaglund
Copy link
Contributor

NellyHaglund commented Sep 30, 2019 •
edited

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
When having a editorValidator on a editable cell, this only validates correctly on enter, not for tab.

Expected behavior
The editorValidator should be triggered and behave the same on both enter and tab.
NellyHaglund added a commit to NellyHaglund/primereact that referenced this issue Oct 1, 2019
@NellyHaglund
Prevent tab default behaviour if validate invalid
8f4e088 
Fixes primefaces#1024
@NellyHaglund NellyHaglund mentioned this issue Oct 1, 2019
Closed
NellyHaglund added a commit to NellyHaglund/primereact that referenced this issue Oct 1, 2019
@NellyHaglund
Prevent tab default behaviour if validate invalid
8f412e0 
Fixes primefaces#1024
@cagataycivici
Copy link
Member

Review for 4.2

@cagataycivici cagataycivici added this to the 4.2.0 milestone Mar 10, 2020
@mertsincan
Copy link
Member

Hi,

Thanks a lot for the PR! I think this issue was fixed with the latest version. Could you please try it with the latest version? If the problem persists, please reopen this ticket.

Best Regards,

@mertsincan mertsincan removed this from the 5.0.0.Final milestone Feb 9, 2021
@mertsincan mertsincan reopened this Nov 3, 2021
@mertsincan mertsincan added this to the 7.0.0.Final milestone Nov 3, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
7.0.0.Final
Development

Successfully merging a pull request may close this issue.

Prevent tab default behaviour if validate invalid NellyHaglund/primereact
3 participants
@cagataycivici @NellyHaglund @mertsincan