Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to Chart.js 3.3.2 #1802

Closed
NathanPB opened this issue Feb 4, 2021 · 7 comments
Closed

Update to Chart.js 3.3.2 #1802

NathanPB opened this issue Feb 4, 2021 · 7 comments
Assignees
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@NathanPB
Copy link
Contributor

NathanPB commented Feb 4, 2021

I'm submitting a ... (check one with "x")

[ ] bug report
[ ? ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

ChartJS 3 is currently in beta, any plans to update the current PrimeReact ChartJS wrapper? I'd like to dig into that and do some work to help the update

@mertsincan
Copy link
Member

Hi @NathanPB,

Can you make these changes after Chart Js released? There may be differences between beta and major releases in our theme.

@NathanPB
Copy link
Contributor Author

NathanPB commented Feb 9, 2021

Hi @NathanPB,

Can you make these changes after Chart Js released? There may be differences between beta and major releases in our theme.

Sure, I'll wait for the release

@mertsincan
Copy link
Member

Thanks a lot, @NathanPB ;) I'll wait for your PR :D

@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add Status: Pending Review Issue or pull request is being reviewed by Core Team labels Feb 9, 2021
@dnairns-arch
Copy link

I am using PrimeReact and would like to see this as one of the updates and features once they release. I have to rewrite around 100+ components to get the functionalities of ChartJS 3, due to a project requirement for horizontal stacked bar charts. I tried upgrading to beta, and had a handful of issues so i ended up writing my own chart component for the HZ Stacked Bar. The line graphs seem to work okay with the default chart class in PrimeReact just FYI.

If you guys could add the ChartJS 3.0 to the feature list when they drop the first release I would greatly appreciate it!

@mertsincan mertsincan added this to the 6.4.0 milestone May 6, 2021
@mertsincan
Copy link
Member

Thanks @dnairns-arch, I'll work on it for 6.4.0.

Best Regards,

@mertsincan mertsincan changed the title ChartJS 3 update? Update to Chart.js 3.3.2 Jun 3, 2021
@mertsincan mertsincan removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Jun 3, 2021
@mertsincan mertsincan assigned mertsincan and unassigned NathanPB Jun 3, 2021
@dattebayorob
Copy link

Break change @mertsincan ?

@mertsincan mertsincan added the Type: Breaking Change Issue contains a breaking change related to a specific component label Jun 15, 2021
@mertsincan
Copy link
Member

Yes, @dattebayorob ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Breaking Change Issue contains a breaking change related to a specific component Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

4 participants