Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputNumber: Arrow keys not working properly #1866

Closed
augustosnk12 opened this issue Mar 11, 2021 · 1 comment · Fixed by #3614
Closed

InputNumber: Arrow keys not working properly #1866

augustosnk12 opened this issue Mar 11, 2021 · 1 comment · Fixed by #3614
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.7.3

Comments

@augustosnk12
Copy link

augustosnk12 commented Mar 11, 2021 •
edited
Loading

[ ] bug report
[x] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)

https://codesandbox.io/s/nervous-pare-tb6rb?file=/src/demo/InputNumberDemo.js

Current behavior
When I perform a select in a InputNumber that has a "suffix" prop enable I'm not able to use keyboard
arrows or backspace to handle the cursor position. It makes me use the mouse to click in the input to be
able to type a value, and for me it's not a good practice...

Expected behavior
Be able to use keyboard arrows when press "tab" key in a InputNumber with "suffix" prop.

Minimal reproduction of the problem with instructions
Instructions are in the codesandbox case.

Please tell us about your environment:
Windows 10

  • React version:
    "react": "^17.0.1"

  • PrimeReact version:
    "primereact": "^6.0.0",

  • Browser: [all]

  • Language: [all]
@mcandu mcandu added the Type: New Feature Issue contains a new feature or new component request label Aug 19, 2021
@melloware melloware self-assigned this May 3, 2022
@melloware melloware changed the title Cursor not working on InputNumber InputNumber: Arrow keys not working properly May 3, 2022
@melloware melloware added Component: Accessibility Issue or pull request is related to WCAG or ARIA and removed Type: New Feature Issue contains a new feature or new component request labels May 3, 2022
@melloware
Copy link
Member

Still an issue in 8.0.1: https://codesandbox.io/s/kind-shamir-g578rh

@melloware melloware removed their assignment May 3, 2022
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 24, 2022
melloware added a commit to melloware/primereact that referenced this issue Nov 11, 2022
@melloware
Fix primefaces#1866: InputNumber arrows keys don't work tabbing into …
e50cf1b 
…symbol field
@melloware melloware removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 11, 2022
@melloware melloware self-assigned this Nov 11, 2022
@melloware melloware added this to the 8.7.3 milestone Nov 11, 2022
@melloware melloware mentioned this issue Nov 11, 2022
Merged
melloware added a commit that referenced this issue Nov 11, 2022
@melloware
Fix #1866: InputNumber arrows keys don't work tabbing into symbol fie…
9b4a1d4 
…ld (#3614)
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Component: Accessibility Issue or pull request is related to WCAG or ARIA labels Nov 11, 2022
@melloware melloware mentioned this issue Nov 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.7.3
Development

Successfully merging a pull request may close this issue.

Fix #1866: InputNumber arrows keys don't work tabbing into symbol field melloware/primereact
4 participants
@melloware @mertsincan @augustosnk12 @mcandu