Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitButton does not carry through the classname #1939

Closed
matthewmartinspok opened this issue Apr 6, 2021 · 1 comment · Fixed by #2461
Closed

SplitButton does not carry through the classname #1939

matthewmartinspok opened this issue Apr 6, 2021 · 1 comment · Fixed by #2461
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
7.1.0

Comments

@matthewmartinspok
Copy link

I'm submitting a ... (check one with "x")

[ x ] bug report
[ x ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
Forked examples below, notice how p-button-text and p-button-rounded are not taking affect.

https://codesandbox.io/s/primereact-test-forked-yqimv

Current behavior
Button types such as text, rounded, raised, and outlined are not taking affect in the SplitButton buttons.

Expected behavior
If I pass in any of the types, such as "p-button-text" I'd expect the text styling to take over in the split button buttons.

Minimal reproduction of the problem with instructions
See codesandbox above

Please tell us about your environment:
Any

  • React version:
    Latest

  • PrimeReact version:
    Latest

  • Browser:
    All

  • Language:
    All
@mcandu mcandu added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Oct 5, 2021
melloware added a commit to melloware/primereact that referenced this issue Nov 23, 2021
@melloware
Fix primefaces#1939/primefaces#1882: SplitButton buttonClassName, men…
f1152ae 
…uButtonClassName
@melloware melloware mentioned this issue Nov 23, 2021
Merged
@melloware
Copy link
Member

PR submitted

mertsincan pushed a commit that referenced this issue Dec 10, 2021
@melloware
Fix #1939/#1882: SplitButton buttonClassName, menuButtonClassName (#2461
ace85c4 
)
@mertsincan mertsincan modified the milestones: 8.0.0, 7.1.0 Dec 10, 2021
melloware added a commit to melloware/primereact that referenced this issue Dec 22, 2021
@melloware
Doc primefaces#1939: Splitbutton buttonClassName, menuButtonClassName…
3c931ef 
… docs and example
@melloware melloware mentioned this issue Dec 22, 2021
Merged
melloware added a commit to melloware/primereact that referenced this issue Jan 7, 2022
@melloware
Doc primefaces#1939: Splitbutton buttonClassName, menuButtonClassName…
710df31 
… docs and example
mertsincan added a commit that referenced this issue Feb 17, 2022
@melloware @mertsincan
Doc #1939: Splitbutton buttonClassName, menuButtonClassName docs and …
c360c4d 
…example (#2546)

Co-authored-by: mertsincan <sincan.mert@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

Fix #1939/#1882: SplitButton buttonClassName, menuButtonClassName melloware/primereact
4 participants
@melloware @mertsincan @matthewmartinspok @mcandu