Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

About defaultProps and propTypes #2

Closed
serayuzgur opened this issue Jan 3, 2017 · 1 comment
Closed

About defaultProps and propTypes #2

serayuzgur opened this issue Jan 3, 2017 · 1 comment

Comments

@serayuzgur
Copy link

Hello,
According to me defaultProps and propTypes as static members are nicer than assigning outside of the class. Do you have a specific reason to go like that?
@cagataycivici
Copy link
Member

We've just started like that but I static members look nicer, will switch to that, thanks!

eirikaho referenced this issue in eirikaho/primereact Oct 29, 2019
Merge pull request #2 in INC/primereact-fork from feature/datatable-o…
e4da885 
…verride-virtual-scroll-height to master

* commit 'bf7f8cc0e5dc73e5d0454cce3582ff07176325c1':
  virtual scroller height set to max of virtualScrollHeightOverride or totalCollapsedHeight
  virtual scroller height set to max of virtualScrollHeightOverride or totalCollapsedHeight
  virtual scroller height set to max of virtualScrollHeightOverride or totalCollapsedHeight
  virtual scroller height set to max of virtualScrollHeightOverride or totalCollapsedHeight
@dmitriy-ssh dmitriy-ssh mentioned this issue Dec 15, 2021
Closed
@melloware melloware mentioned this issue Aug 7, 2022
Closed
@pkmarcotte pkmarcotte mentioned this issue Jan 18, 2023
Closed
@djuuuuus djuuuuus mentioned this issue Oct 3, 2023
Open
@jimduchek jimduchek mentioned this issue Mar 30, 2024
Closed
gucal added a commit that referenced this issue Apr 4, 2024
@gucal
Merge pull request #2 from gucal/matching-demo
f515af1 
Remove pt doc
@mgmodell mgmodell mentioned this issue May 3, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cagataycivici @serayuzgur