Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Button icon classes listed twice #2415

Closed
kalinkrustev opened this issue Nov 11, 2021 · 1 comment
Closed

Button icon classes listed twice #2415

kalinkrustev opened this issue Nov 11, 2021 · 1 comment
Assignees
@mertsincan
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
7.0.1

Comments

@kalinkrustev
Copy link
Contributor

I'm submitting a ... (check one with "x")

[ x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
Button icon classes are repeated

Expected behavior
Button icon classes to be applied only once

Minimal reproduction of the problem with instructions

It is observed at the showcase:
See comment here:
a42c765#r60102956

  • PrimeReact version:
    7.0.0
@mertsincan mertsincan self-assigned this Nov 11, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Nov 11, 2021
@mertsincan mertsincan added this to the 8.0.0 milestone Nov 11, 2021
@mertsincan
Copy link
Member

Gooood catch! Thanks a lot for this issue!

Best Regards,

mertsincan added a commit that referenced this issue Nov 11, 2021
@mertsincan
refactor #2415
77b1ce4
@mertsincan mertsincan modified the milestones: 8.0.0, 7.0.1 Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mertsincan mertsincan

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
7.0.1
Development

No branches or pull requests
2 participants
@kalinkrustev @mertsincan