Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ConfirmDialogProps breaks the build on Typescript due to double semicolon #2429

Closed
LinoBert opened this issue Nov 14, 2021 · 1 comment · Fixed by #2430
Closed

ConfirmDialogProps breaks the build on Typescript due to double semicolon #2429

LinoBert opened this issue Nov 14, 2021 · 1 comment · Fixed by #2430
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
7.0.1

Comments

@LinoBert
Copy link

I'm submitting a ...

[ x ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
There is a small typo in the Type definition of the ConfirmDialogProps interface(Line 31+32).
https://github.com/primefaces/primereact/blob/master/src/components/confirmdialog/ConfirmDialog.d.ts#L31
The two semicolons break the build.
TS1131: Property or signature expected.

Expected behavior
There is only one or no semicolon

  • React version:
    17.0.1

  • PrimeReact version:
    7.0.0

  • Language: [TypeScript 3.9.9]
melloware added a commit to melloware/primereact that referenced this issue Nov 14, 2021
@melloware
Fix primefaces#2429: ConfirmDialog Typescript double semicolon
f05ff02
melloware added a commit to melloware/primereact that referenced this issue Nov 14, 2021
@melloware
Fix primefaces#2429: ConfirmDialog Typescript remove double semicolon
4e4fddc
@melloware melloware mentioned this issue Nov 14, 2021
Merged
@melloware
Copy link
Member

PR Submitted....

mertsincan pushed a commit that referenced this issue Nov 15, 2021
@melloware
Fix #2429: ConfirmDialog Typescript remove double semicolon (#2430)
58898a4
@mertsincan mertsincan changed the title Primereact 7.0.0 - ConfirmDialogProps breaks the build on Typescript due to double semicolon ConfirmDialogProps breaks the build on Typescript due to double semicolon Nov 15, 2021
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Nov 15, 2021
@mertsincan mertsincan added this to the 7.0.1 milestone Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
7.0.1
Development

Successfully merging a pull request may close this issue.

Fix #2429: ConfirmDialog Typescript remove double semicolon melloware/primereact
3 participants
@melloware @mertsincan @LinoBert