Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

InputNumber Critical Issue #2465

Closed
IHPNULL opened this issue Nov 24, 2021 · 4 comments · Fixed by #2472
Closed

InputNumber Critical Issue #2465

IHPNULL opened this issue Nov 24, 2021 · 4 comments · Fixed by #2472
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@IHPNULL
Copy link

IHPNULL commented Nov 24, 2021

There is no guarantee in receiving an immediate response in GitHub Issue Tracker, If you'd like to secure our response, you may consider PrimeReact PRO Support where support is provided within 4 business hours

I'm submitting a ... (check one with "x")

[X] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)
https://codesandbox.io/s/primereact-test-forked-i946f

Current behavior
When uses InputNumber property "min"

Expected behavior
if Input a letter this letter will never appear, and when the component delete this letter respect the min property

Minimal reproduction of the problem with instructions
create a <InputNumber with min property and put a letter on the input, then the input will delete de letter but will delete everything and the value become 0, ignoring the min property

Please tell us about your environment:
Windows 10
node 16.13.0
react 17.0.2
primeReact 7.0.1

  • React version:
    react 17.0.2

  • PrimeReact version:
    primeReact 7.0.1

  • Browser:

  • [ Chrome XX ]

  • Language: [ES6/7]

@melloware
Copy link
Member

melloware commented Nov 25, 2021

You didn't provide a CodeSandbox demo for us to see the issue? Your link above takes me to the default test case.

@IHPNULL
Copy link
Author

IHPNULL commented Nov 25, 2021

You didn't provide a CodeSandbox demo for us to see the issue? Your link above takes me to the default test case.

sorry, now I updated the CodeSandbox, please check asap

@melloware
Copy link
Member

PR Submitted please review.

@mertsincan mertsincan added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Dec 10, 2021
@mertsincan mertsincan added this to the 8.0.0 milestone Dec 10, 2021
mertsincan added a commit that referenced this issue Dec 10, 2021
@mertsincan
Copy link
Member

Hi,

I made some changes in PR. I think if there is a min value, the min value can be set into field.
Exp: min={-20} -> field: -20 not 0

Thanks a lot for PR, @melloware ;)

@mertsincan mertsincan modified the milestones: 8.0.0, 7.1.0 Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants