Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOMException in DataTable after React fast refresh #2469

Closed
kalinkrustev opened this issue Nov 25, 2021 · 3 comments · Fixed by #2471
Closed

DOMException in DataTable after React fast refresh #2469

kalinkrustev opened this issue Nov 25, 2021 · 3 comments · Fixed by #2471
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
7.1.0

Comments

@kalinkrustev
Copy link
Contributor

I'm submitting a ... (check one with "x")

[x ] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Current behavior
After React fast refresh, the following error is thrown by DataTable:
DOMException: Failed to execute 'removeChild' on 'Node': The node to be removed is not a child of this node.
Check #2468 for a fix.

Expected behavior
No error should be thrown.

Minimal reproduction of the problem with instructions
Create a storybook with DataTable and trigger react fast refresh.

PrimeReact version:
7.0.1
melloware added a commit to melloware/primereact that referenced this issue Nov 25, 2021
@melloware
Fix primefaces#2469: Remove inline styles and prevent DOM Exception
2212ca8
@melloware melloware mentioned this issue Nov 25, 2021
Merged
@melloware
Copy link
Member

@kalinkrustev please review my PR: #2471

melloware added a commit to melloware/primereact that referenced this issue Nov 25, 2021
@melloware
Fix primefaces#2469: Remove inline styles and prevent DOM Exception
50c4a24
melloware added a commit to melloware/primereact that referenced this issue Nov 25, 2021
@melloware
Fix primefaces#2469: Remove inline styles and prevent DOM Exception
53c29da
@kalinkrustev
Copy link
Contributor Author

Yes, I was suspecting there might be a better approach than what I proposed. Looks good.

@melloware
Copy link
Member

Plus I figured I would find every place doing this and not just DataTable as it could happen in OverlayPanels too. Thanks for reviewing.

mertsincan pushed a commit that referenced this issue Dec 10, 2021
@melloware
Fix #2469: Remove inline styles and prevent DOM Exception (#2471)
110cb93
@mertsincan mertsincan added the Type: Bug Issue contains a defect related to a specific component. label Dec 10, 2021
@mertsincan mertsincan added this to the 8.0.0 milestone Dec 10, 2021
mertsincan added a commit that referenced this issue Dec 10, 2021
@mertsincan
Refactor #2469
dcd7954
@mertsincan mertsincan modified the milestones: 8.0.0, 7.1.0 Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
7.1.0
Development

Successfully merging a pull request may close this issue.

Fix #2469: Remove inline styles and prevent DOM Exception melloware/primereact
3 participants
@kalinkrustev @melloware @mertsincan