Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: ContextMenu showcase/theme doesn't highlight selection #2526

Closed
VsevolodGolovanov opened this issue Dec 15, 2021 · 1 comment · Fixed by #3676
Closed

DataTable: ContextMenu showcase/theme doesn't highlight selection #2526

VsevolodGolovanov opened this issue Dec 15, 2021 · 1 comment · Fixed by #3676
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
8.7.3

Comments

@VsevolodGolovanov
Copy link

I'm submitting a ... (check one with "x")

[x] bug report
[ ] feature request
[ ] support request => Please do not submit support request here, instead see https://forum.primefaces.org/viewforum.php?f=57

Codesandbox Case (Bug Reports)

Current behavior
https://www.primefaces.org/primereact/datatable/contextmenu/ demonstrates using contextMenuSelection and onContextMenuSelectionChange, and they do add the p-highlight-contextmenu class, but it has no visual effect.
image

Expected behavior
The row should be highlighted visually to indicate the object of the menu.

Minimal reproduction of the problem with instructions

Please tell us about your environment:

  • React version:

  • PrimeReact version:
    7.1.0

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

  • Language: [all | TypeScript X.X | ES6/7 | ES5]
@yigitfindikli yigitfindikli added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Mar 22, 2022
@melloware melloware added Component: Theme Issue or pull request is related to Theme and removed Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels May 5, 2022
@melloware melloware added this to the 8.1.0 milestone May 5, 2022
@mertsincan mertsincan modified the milestones: 8.2.0, 9.0.0 Jul 6, 2022
@mertsincan mertsincan added the Status: Pending Review Issue or pull request is being reviewed by Core Team label Aug 24, 2022
@melloware melloware removed the Status: Pending Review Issue or pull request is being reviewed by Core Team label Nov 18, 2022
melloware added a commit to melloware/primereact that referenced this issue Nov 18, 2022
@melloware
Fix primefaces#2526: DataTable contextmenu selection highlight
5e95af5
@melloware melloware assigned melloware and unassigned mertsincan Nov 18, 2022
@melloware melloware modified the milestones: 9.0.0, 8.7.3 Nov 18, 2022
@melloware melloware mentioned this issue Nov 18, 2022
Merged
@melloware
Copy link
Member

image

melloware added a commit that referenced this issue Nov 18, 2022
@melloware
Fix #2526: DataTable contextmenu selection highlight (#3676)
a6f0f3b
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Component: Theme Issue or pull request is related to Theme labels Nov 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
8.7.3
Development

Successfully merging a pull request may close this issue.

Fix #2526: DataTable contextmenu selection highlight melloware/primereact
4 participants
@melloware @VsevolodGolovanov @mertsincan @yigitfindikli