Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SplitButton: menu icon not visible in large size #4483

Closed
habubey opened this issue Jun 5, 2023 · 1 comment · Fixed by #4488
Closed

SplitButton: menu icon not visible in large size #4483

habubey opened this issue Jun 5, 2023 · 1 comment · Fixed by #4488
Assignees
@ulasturann @habubey
Labels
Component: Theme Issue or pull request is related to Theme Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component.
Milestone
9.6.0

Comments

@habubey
Copy link
Contributor

habubey commented Jun 5, 2023

Describe the bug

The icon is not visible when the SplitButton component is used with a large size. The issue occurs specifically in cases where the SplitButton gets a size large property in most of the themes (ex: except for the nano theme).

Screenshot 2023-06-05 at 10 19 53

Reproducer

No response

PrimeReact version

9.5.0

React version

17.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Screenshot 2023-06-05 at 10 22 03
@habubey habubey added Type: Bug Issue contains a defect related to a specific component. Component: Theme Issue or pull request is related to Theme Core Team Issue or pull request has been *opened* by a member of Core Team labels Jun 5, 2023
@habubey habubey added this to the 9.6.0 milestone Jun 5, 2023
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 5, 2023
@habubey habubey removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jun 5, 2023
@tugcekucukoglu tugcekucukoglu mentioned this issue Jun 6, 2023
Closed
This was referenced Jun 7, 2023
Closed
Merged
habubey added a commit that referenced this issue Jun 7, 2023
@habubey
Fixed #4483 - SplitButton: menu icon not visible in large size
104b24a
@habubey habubey mentioned this issue Jun 7, 2023
Merged
@habubey habubey linked a pull request Jun 7, 2023 that will close this issue
Fixed #4483 - SplitButton: menu icon not visible in large size #4488
Merged
melloware pushed a commit that referenced this issue Jun 12, 2023
@habubey @melloware
Fixed #4483 - SplitButton: menu icon not visible in large size
25bf2cb
@habubey
Copy link
Contributor Author

habubey commented Jun 26, 2023

Fixed from sass theme:
primefaces/primereact-sass-theme#19

ulasturann added a commit that referenced this issue Jun 27, 2023
@ulasturann
Merge pull request #4488 from primefaces/issue-4483
5874de2 
Fixed #4483 - SplitButton: menu icon not visible in large size
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ulasturann ulasturann

@habubey habubey

Labels
Component: Theme Issue or pull request is related to Theme Core Team Issue or pull request has been *opened* by a member of Core Team Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
9.6.0
Development

Successfully merging a pull request may close this issue.

Fixed #4483 - SplitButton: menu icon not visible in large size primefaces/primereact
2 participants
@ulasturann @habubey