Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

InputNumber: button event repeats infinitely if input is disabled #5245

Closed
dmit4git opened this issue Nov 5, 2023 · 1 comment · Fixed by #5249
Closed

InputNumber: button event repeats infinitely if input is disabled #5245

dmit4git opened this issue Nov 5, 2023 · 1 comment · Fixed by #5249
Assignees
@melloware
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.1.0

Comments

@dmit4git
Copy link

dmit4git commented Nov 5, 2023

Describe the bug

If onValueChange handler of InputNumber disables the component, then event generated by clicking on the component's button keeps reoccurring infinitely.
ezgif-4-c2be353dd6

Same bug was reported on primeng primefaces/primeng#9888

Reproducer

https://codesandbox.io/s/primereact-demo-forked-lvwxvl

PrimeReact version

10.0.x

React version

17.x

Language

ES6

Build / Runtime

Create React App (CRA)

Browser(s)

Chrome, Firefox

Steps to reproduce the behavior

Click on + or - button of the InputNumber component.

Expected behavior

Single button click should generate a single value change event.
@dmit4git dmit4git added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 5, 2023
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 6, 2023
@melloware melloware self-assigned this Nov 6, 2023
@melloware melloware added this to the 10.0.10 milestone Nov 6, 2023
melloware added a commit to melloware/primereact that referenced this issue Nov 6, 2023
@melloware
Fix primefaces#5245: InputNumber prevent infinite loop
1362571
@melloware melloware mentioned this issue Nov 6, 2023
Merged
@melloware
Copy link
Member

PR submitted thanks for the bug report!

melloware added a commit that referenced this issue Nov 6, 2023
@melloware
Fix #5245: InputNumber prevent infinite loop (#5249)
432ec35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melloware melloware

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.1.0
Development

Successfully merging a pull request may close this issue.

Fix #5245: InputNumber prevent infinite loop melloware/primereact
2 participants
@melloware @dmit4git