Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Preview toolbar buttons only close the preview in unstyled NextJS 14 #6037

Closed
melloware opened this issue Feb 23, 2024 · 0 comments · Fixed by #6038
Closed

Image: Preview toolbar buttons only close the preview in unstyled NextJS 14 #6037

melloware opened this issue Feb 23, 2024 · 0 comments · Fixed by #6038
Assignees
Labels
Component: NextJS NextJS related issue Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@melloware
Copy link
Member

melloware commented Feb 23, 2024

Discussed in https://github.com/orgs/primefaces/discussions/1267

Originally posted by baracuda69 February 23, 2024
When clicking on an image to open preview, the preview opens as expected (although the image dimensions are too large to fit on-screen - which can be addressed with custom css).

However, the toolbar (with the rotate, zoom and close icons) does not function;
Any button/icon clicked on that toolbar simply closes the image preview (previewcontainer).

I have tried to add some custom css to adjust the z-index of the previewcontainer, toolbar, but to no avail.

https://stackblitz.com/edit/stackblitz-starters-3gzjrf?file=app%2Fpage.tsx

Note that stackblitz originally configured next.js v13.x, and the problem I mentioned did not exist;
However, after updating to next.js v14 the problem is as reported.

You can, of course, see all package versions in package.json.

@melloware melloware transferred this issue from primefaces/community Feb 23, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Feb 23, 2024
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. Component: NextJS NextJS related issue and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Feb 23, 2024
@melloware melloware changed the title Image Preview toolbar buttons only close the preview, when using unstyled and Tailwind as Passthrough Options Image: Preview toolbar buttons only close the preview in unstyled NextJS 14 Feb 23, 2024
melloware added a commit to melloware/primereact that referenced this issue Feb 23, 2024
@melloware melloware self-assigned this Feb 23, 2024
@melloware melloware added this to the 10.5.2 milestone Feb 23, 2024
nitrogenous added a commit that referenced this issue Mar 18, 2024
Fix #6037: Image stop click propagation on preview buttons
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: NextJS NextJS related issue Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant