Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Showcase: Icon Spacing incorrect #6379

Closed
melloware opened this issue Apr 11, 2024 · 2 comments · Fixed by #6386
Closed

Showcase: Icon Spacing incorrect #6379

melloware opened this issue Apr 11, 2024 · 2 comments · Fixed by #6386
Assignees
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a defect related to a specific component.
Milestone

Comments

@melloware
Copy link
Member

See: https://primereact.org/datatable/#basic_filter

image

Notice the icon is crammed together. This looks like a recent change.

@melloware melloware added the Component: Theme Issue or pull request is related to Theme label Apr 11, 2024
@github-actions github-actions bot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 11, 2024
@sandramfdeveloper
Copy link

You have to change the code of the example to the new IconField and IconInput i think, find them and replace (i think it's in many more places, but i don't remember where). The other day I have the same issue on my project.

<IconField iconPosition="left">
    <InputIcon className="pi pi-search" />
    <InputText placeholder="placeholder" value={value} onChange={handleChange} />
  </IconField>

@melloware
Copy link
Member Author

Ahhh great call @sandramfdeveloper let me fix the Showcase!

@melloware melloware assigned melloware and unassigned nitrogenous and gucal Apr 12, 2024
@melloware melloware removed the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 12, 2024
@melloware melloware added this to the 10.6.4 milestone Apr 12, 2024
@melloware melloware added Component: Documentation Issue or pull request is related to Documentation and removed Component: Theme Issue or pull request is related to Theme labels Apr 12, 2024
@melloware melloware changed the title Theme: Icon Spacing incorrect Showcase: Icon Spacing incorrect Apr 12, 2024
melloware added a commit to melloware/primereact that referenced this issue Apr 12, 2024
@nitrogenous nitrogenous added the Type: Bug Issue contains a defect related to a specific component. label Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Documentation Issue or pull request is related to Documentation Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants