Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Toast always closes all messages #6456

Closed
tweiler0309 opened this issue Apr 24, 2024 · 4 comments · Fixed by #6457, leoo1992/GeradorQRCode#23 or leoo1992/GeradorQRCode#27
Closed

Toast always closes all messages #6456

tweiler0309 opened this issue Apr 24, 2024 · 4 comments · Fixed by #6457, leoo1992/GeradorQRCode#23 or leoo1992/GeradorQRCode#27
Assignees
@Rekl0w
Labels
Type: Bug Issue contains a defect related to a specific component.
Milestone
10.6.4

Comments

@tweiler0309
Copy link

Describe the bug

Closing one of several messages closes all messages. Independent of their sticky-value. This is a breaking behaviour opposit to PrimeReact 9.6.5. This behaviour can be reproduced in both official demo-applications of PrimeReact (10.6.3 vs. 9.6.5)
Closing a single message and leave all other messages open is important.
How to deal with it in 10.6.3?
Thx guys!

Reproducer

No response

PrimeReact version

10.6.3

React version

18.x

Language

TypeScript

Build / Runtime

Create React App (CRA)

Browser(s)

Google Chrome Version 122.0.6261.129 (Offizieller Build) (64-Bit)

Steps to reproduce the behavior

Please compare behaviour in both demo of Primereact (10.6.3 vs. 9.6.5)

Expected behavior

Every toast should be closed on its own
@tweiler0309 tweiler0309 added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Apr 24, 2024
@Rekl0w Rekl0w mentioned this issue Apr 24, 2024
Merged
@melloware melloware added Type: Bug Issue contains a defect related to a specific component. and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Apr 24, 2024
@melloware melloware added this to the 10.6.4 milestone Apr 24, 2024
@melloware
Copy link
Member

Agreed its related to these changes

#5972

#5083

@Rekl0w
Copy link
Contributor

Rekl0w commented Apr 24, 2024

PR updated. It works good now.

@tweiler0309
Copy link
Author

Awesome! Well done!
Cheers,
Thorsten

melloware pushed a commit that referenced this issue Apr 24, 2024
@Rekl0w
Fix #6456 : Toast close by id fix (#6457)
c35496f 
* Fix #6456

* Fix #6456 update

* Fix #6456 update

* Fix #6456 messages fix
@Rekl0w
Copy link
Contributor

Rekl0w commented Apr 24, 2024

Messages had that bug too, i fixed it.

This was referenced May 21, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Rekl0w Rekl0w

Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Milestone
10.6.4
3 participants
@melloware @Rekl0w @tweiler0309