Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Buttons already accept custom icons, but most other components do not. This changes allows all components that have icon props to use custom icons, similar to Buttons.
The main changes are
IconUtils
class that has a methodgetJSXIcon
. This method is based onrenderIcon
in theButton
class. For strings, it will create aspan
with the string as theclassName
. ForReact.ReactNode
objects or functions that return aReact.ReactNode
object, it will wrap the object in a span and return itgetJSXIcon
instead of creatingspan
ori
icons directlyI don't know if this will be merged, but I thought it might useful to other people who want to use custom icons