Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #2346: Yarn package.json correction #2351

Merged
merged 1 commit into from Nov 3, 2021

Conversation

melloware
Copy link
Member

@melloware melloware commented Oct 16, 2021

Fixed #2346 When using Yarn PnP with e.g. webpack it results in an error because primereact attempts to import react-transition-group, but does not declare it in its dependencies. Yarn PnP requires that a package explicitly declares all packages it uses.

@mertsincan mertsincan merged commit 524cb27 into primefaces:master Nov 3, 2021
@melloware melloware deleted the PR2346 branch November 3, 2021 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(Yarn PnP) Add react-transition-group as optional peer dependency
2 participants