Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treeselect resolution for node ids equals to 0 #2375

Merged
merged 4 commits into from Nov 3, 2021

Conversation

flashboss
Copy link
Contributor

###Defect Fixes
When submitting a PR, please also create an issue documenting the error.

###Feature Requests
Due to company policy, we are unable to accept feature request PRs with significant changes as such cases has to be implemented by our team following our own processes.
Smaller scaled feature implementations such as adding a property to a component will be considered for merging.

@flashboss
Copy link
Contributor Author

It resolves the bug identified by #2372

@melloware
Copy link
Member

I think you can do this...

if (ObjectUtils.isNotEmpty(this.props.value) && this.props.options) {

PrimeReact has that custom ObjecUtils method which specifically does not look for 0 as falsy.

Copy link
Member

@melloware melloware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see my comment

@flashboss
Copy link
Contributor Author

good

@mertsincan mertsincan merged commit 679f917 into primefaces:master Nov 3, 2021
@mertsincan
Copy link
Member

Nice teamwork! Thanks a lot for your contribution!

Best Regards,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants