Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #5849: Splitter improve ARIA accessibility #5852

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

melloware
Copy link
Member

Fix #5849: Splitter improve ARIA accessibility

@melloware melloware added the Core Team Issue or pull request has been *opened* by a member of Core Team label Jan 29, 2024
Copy link

vercel bot commented Jan 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 9:11pm
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview Jan 29, 2024 9:11pm

Copy link

@sharvell-collegeboard sharvell-collegeboard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks awesome, thanks for amazingly fast work!!!

@melloware melloware merged commit 8f45106 into primefaces:master Jan 29, 2024
6 checks passed
@melloware melloware deleted the PR5849 branch January 29, 2024 21:12
@jmegginson
Copy link

The accurate ARIA role is "separator" (role="separator") even though it's colloquially referred to as splitter.

@melloware
Copy link
Member Author

Thanks fixed role with https://github.com/primefaces/primereact/pull/5853/files

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Team Issue or pull request has been *opened* by a member of Core Team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Splitter: missing/incorrect accessibility features
3 participants