Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added new capabilities and properties to Column and Dialog #6611

Merged
merged 10 commits into from
May 15, 2024
Merged

Added new capabilities and properties to Column and Dialog #6611

merged 10 commits into from
May 15, 2024

Conversation

didix16
Copy link
Contributor

@didix16 didix16 commented May 11, 2024

This fixes some problmes with autocomplete component with dialog
Issue #6569

Copy link

vercel bot commented May 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Ignored Deployments
Name Status Preview Comments Updated (UTC)
primereact ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 9:26am
primereact-v9 ⬜️ Ignored (Inspect) Visit Preview May 14, 2024 9:26am

components/lib/dialog/Dialog.js Outdated Show resolved Hide resolved
@didix16 didix16 requested a review from melloware May 12, 2024 18:35
@melloware
Copy link
Member

Ok let me think about a better name for the prop then!

@didix16
Copy link
Contributor Author

didix16 commented May 12, 2024

Perfect, thanks! By the way, should I set onKeyDown event prevention to be done always and remove the Dialog property?

@melloware
Copy link
Member

Yes just default that on key down

@didix16
Copy link
Contributor Author

didix16 commented May 12, 2024

I just removed the property added to Dialog and now the onKeyDown propagation event is stoped by default. Also I restored back the Dialog api.

components/lib/dialog/DialogBase.js Outdated Show resolved Hide resolved
components/lib/column/column.d.ts Outdated Show resolved Hide resolved
@didix16
Copy link
Contributor Author

didix16 commented May 13, 2024

I've applied the remaining changes. Removed the unused property and changed the other one. It should be ready to go.

@didix16
Copy link
Contributor Author

didix16 commented May 14, 2024

@melloware I've removed a typo in BodyCell.js that formatter checker was preventing to merge the code. Hope now can pass the merge process...

@melloware melloware added the Status: Pending Test Issue or pull request is being tested by Core Team label May 14, 2024
@melloware
Copy link
Member

Assigned to PrimeTek for review!

@nitrogenous
Copy link
Contributor

Looks good! Superb

@nitrogenous nitrogenous added Type: Bug Issue contains a defect related to a specific component. and removed Status: Pending Test Issue or pull request is being tested by Core Team labels May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a defect related to a specific component.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants