Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable should use max-height for scrollable #30

Closed
cagataycivici opened this issue Jun 24, 2015 · 1 comment
Closed

DataTable should use max-height for scrollable #30

cagataycivici opened this issue Jun 24, 2015 · 1 comment
Assignees
Milestone

Comments

@cagataycivici
Copy link
Member

Posted at our forum;

I think that scrollable datatable scrollBody should have line

this.scrollBody.height(this.options.scrollHeight);

replaced with:

this.scrollBody.css('max-height', this.options.scrollHeight);

For example if scrollHeight == 500 then datatable with just one row looks really weird. It is far better to use max-height in script or at least give it on option. In my case, having big empty table with one row is just unacceptable. So either it should be on option or always max-height. I think that even in Primfaces you have max-height, not height.

@cagataycivici cagataycivici self-assigned this Jun 24, 2015
@cagataycivici cagataycivici added this to the 2.0.1 milestone Jun 24, 2015
@cagataycivici cagataycivici modified the milestones: 2.1, 2.0.1 Aug 10, 2015
@vsrihari9
Copy link

How is it fixed? I'm using scrollHeight attribute and still see this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants