Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix toast styling when summary prop is not added #165

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

mbaljeetsingh
Copy link
Contributor

@mbaljeetsingh mbaljeetsingh commented Feb 28, 2024

Hi

If we use the toast component without the summary field. The styles are not correct

image

Updated presets (Lara, Wind) to show it correctly. Centered the content vertically if the summary is not there and removed margin-top from the detail.

image

Fix demo: https://stackblitz.com/edit/icxzv3?file=src%2FApp.vue,src%2Fpresets%2Fwind%2Ftoast%2Findex.js,src%2Fpresets%2Flara%2Ftoast%2Findex.js,src%2Fmain.js

Copy link

vercel bot commented Feb 28, 2024

@mbaljeetsingh is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@atakantepe atakantepe self-requested a review March 11, 2024 17:14
@atakantepe atakantepe self-assigned this Mar 11, 2024
@atakantepe atakantepe added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add labels Mar 11, 2024
@atakantepe atakantepe added this to the 0.8.2 milestone Mar 11, 2024
@atakantepe atakantepe merged commit 228bcfb into primefaces:main Mar 11, 2024
1 check failed
@atakantepe
Copy link
Member

Hi, thank you for your contributions. I merged your PR, and we will have a release this week. 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants