Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add border to invalid input #184

Merged
merged 4 commits into from
Mar 25, 2024

Conversation

henchaves
Copy link
Contributor

The InputText.vue component doesn't change the color of its border when the input value is not following the rules of the required type.

Then, I added invalid:focus:ring-red-200 and invalid:hover:border-red-500 classes to InputText in lara preset.

Copy link

vercel bot commented Mar 13, 2024

@henchaves is attempting to deploy a commit to the primetek Team on Vercel.

A member of the Team first needs to authorize it.

@AnthonyRuelle
Copy link

Hello,

It seems to be the same for all other inputs, could you add this for all :) ?

@henchaves
Copy link
Contributor Author

Hello,

It seems to be the same for all other inputs, could you add this for all :) ?

Hey @AnthonyRuelle !

I added to InputNumber, InputMask and InputOtp. I think the other ones are not necessary.
WDYT?

@AnthonyRuelle
Copy link

Hello !

personally I would have added it to all inputs since they can all be embedded in a form and be invalid if required and not completed.

In my case I use for example the textarea, date or even the dropdown :)

@atakantepe atakantepe merged commit 3897c8c into primefaces:main Mar 25, 2024
1 check failed
@atakantepe
Copy link
Member

Hi, thank you a lot for the contributions. I'll add the focus and hovers for invalid states to the rest of them, including the wind version. This PR will be available with the 0.8.3. I plan to release it this week.🌟

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants