Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

primevue/config: TypeScript error due to unexported type #1164

Closed
zmwangx opened this issue Apr 10, 2021 · 0 comments · Fixed by #1165
Closed

primevue/config: TypeScript error due to unexported type #1164

zmwangx opened this issue Apr 10, 2021 · 0 comments · Fixed by #1165
Assignees
@cagataycivici
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.4.0

Comments

@zmwangx
Copy link
Contributor

zmwangx commented Apr 10, 2021

When importing primevue/config in TypeScript, the following error occurs:

Module '"vue"' has no exported member 'PluginFunction'.

This is because vue 3 does not export a PluginFunction type. Only Plugin is exported.

https://github.com/vuejs/vue-next/blob/f0cf14bcc56c387372932e7d730f838ece17fe5f/packages/runtime-core/src/apiCreateApp.ts#L90-L96
zmwangx added a commit to zmwangx/primevue that referenced this issue Apr 10, 2021
@zmwangx
Fix plugin type in config/PrimeVue.d.ts
dfe7d3f 
vue 3 does not export a PluginFunction type. The install function should be of
type PluginInstallFunction, but even that isn't exported. Instead we declare
the type of the default export as Plugin.

See
https://github.com/vuejs/vue-next/blob/f0cf14bcc56c387372932e7d730f838ece17fe5f/packages/runtime-core/src/apiCreateApp.ts#L90-L96.

Fixes primefaces#1164.
@zmwangx zmwangx mentioned this issue Apr 10, 2021
Merged
zmwangx added a commit to zmwangx/primevue that referenced this issue Apr 10, 2021
@zmwangx
Fix plugin type in config/PrimeVue.d.ts
11e2398 
vue 3 does not export a PluginFunction type. The install function should be of
type PluginInstallFunction, but even that isn't exported. Instead we declare
the type of the default export as Plugin.

See
https://github.com/vuejs/vue-next/blob/f0cf14bcc56c387372932e7d730f838ece17fe5f/packages/runtime-core/src/apiCreateApp.ts#L90-L96.

Fixes primefaces#1164.
@cagataycivici cagataycivici self-assigned this Apr 14, 2021
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Apr 14, 2021
@cagataycivici cagataycivici added this to the 3.4.0 milestone Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cagataycivici cagataycivici

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.4.0
Development

Successfully merging a pull request may close this issue.

Fix plugin type in config/PrimeVue.d.ts zmwangx/primevue
2 participants
@cagataycivici @zmwangx