Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toast center positioning enhancement #1315

Closed
johnthreevolts opened this issue Jun 3, 2021 · 1 comment
Closed

Toast center positioning enhancement #1315

johnthreevolts opened this issue Jun 3, 2021 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add vue2-portable
Milestone

Comments

@johnthreevolts
Copy link

I'm submitting a:

[ x] bug report

Current behavior
https://codesandbox.io/s/competent-cerf-fzw5n
Currently toasts in different position aren't aligned to center equally.
Also they may not feet on mobile screen width.
Would be nice if fix would be available in next version, and backported in PrimeVue2.X branch if it isn't completely frozen.

Expected behavior
https://codesandbox.io/s/nostalgic-pond-zonqx
Possible solution, copy from sandbox index.css:
Except important, as they needed to overwrite default properties.

.p-toast {
  width: min(25rem, 100vw) !important;
}
.p-toast-top-center {
  top: 20px !important;
  left: 0 !important;
  right: 0 !important;
  margin: 0 auto 0 auto !important;
}
.p-toast-top-center {
  left: 0 !important;
  right: 0 !important;
  margin: 0 auto 0 auto !important;
}
.p-toast-bottom-center {
  left: 0 !important;
  right: 0 !important;
  bottom: 20px !important;
  margin: 0 auto 0 auto !important;
}

Vue version: 3.0.6

PrimeVue version: 3.5.0

Browser: [all]

@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add vue2-portable labels Jun 9, 2021
@tugcekucukoglu tugcekucukoglu added this to the 3.5.1 milestone Jun 9, 2021
@tugcekucukoglu tugcekucukoglu self-assigned this Jun 9, 2021
@tugcekucukoglu tugcekucukoglu changed the title Toast width & positioning issue Toast center positioning enhancement Jun 9, 2021
@tugcekucukoglu
Copy link
Member

Thanks for your contribution. It will ported PrimeVue 2 for next release. It is not frozen.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add vue2-portable
Projects
None yet
Development

No branches or pull requests

2 participants