Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion tab-open and tab-close events #1329

Closed
sid-6581 opened this issue Jun 9, 2021 · 3 comments
Closed

Accordion tab-open and tab-close events #1329

sid-6581 opened this issue Jun 9, 2021 · 3 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2
Milestone

Comments

@sid-6581
Copy link
Contributor

sid-6581 commented Jun 9, 2021

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

Current behavior

In 2.4.2 all the code for emitting tab-open and tab-close events was removed. It remains in master for the 3.x versions, so this does not seem intentional. The documentation still reflects tab-open and tab-close as events that are emitted.

Expected behavior

Expect tab-open and tab-close events.

  • Vue version: 2.6.12

  • PrimeVue version: 2.4.2

  • Browser: [all]

@sid-6581
Copy link
Contributor Author

sid-6581 commented Jun 9, 2021

5d2778a is the commit that appeared to break these events. @tugcekucukoglu

@tugcekucukoglu
Copy link
Member

Thanks for your report , we will fix it for next version.

@tugcekucukoglu tugcekucukoglu self-assigned this Jun 11, 2021
@tugcekucukoglu tugcekucukoglu changed the title Accordion no longer emits tab-open and tab-close events in 2.4.2 Accordion tab-open and tab-close events Jun 14, 2021
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2 labels Jun 14, 2021
@tugcekucukoglu tugcekucukoglu added this to the 2.4.3 milestone Jun 14, 2021
@Messias-Ferreira
Copy link

forecast to update NPM ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2
Projects
None yet
Development

No branches or pull requests

3 participants