Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dropdown search don't work with Gboard #1389

Closed
reencafesas opened this issue Jul 28, 2021 · 4 comments
Closed

Dropdown search don't work with Gboard #1389

reencafesas opened this issue Jul 28, 2021 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable
Milestone

Comments

@reencafesas
Copy link

Hello,

the search in the dropdown component does not search and does not work correctly when using the google keyboard, many users bring this keyboard by default, the error is reproducible from any phone with updated gboard even in beta phase

primevueerror

primevueerrorotherkeyboard

[ x] bug report

  • PrimeVue version: 3.6.0

  • Browser: [Mobile Chrome | Android X.X Web Browser]

@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Aug 19, 2021
@cagataycivici cagataycivici added this to the 3.7.0 milestone Aug 19, 2021
@mertsincan
Copy link
Member

Hi,

Thanks a lot for the gifs! But, It is quite difficult for me to replicate this problem. That's why I prepared two different codesandbox links for you.

  1. https://codesandbox.io/s/distracted-silence-7zcn0?file=/index.html What are the outputs for both keyboards?
  2. https://codesandbox.io/s/crazy-allen-2jvuc?file=/src/DropdownDemo.vue Please see Dropdown.computed.visibleOptions method in main.js. Could you please debug it? What is the this.filterValue?

Best Regards,

@mertsincan mertsincan added the Resolution: Cannot Replicate Issue could not be replicated by Core Team label Aug 25, 2021
@mertsincan mertsincan removed this from the 3.7.0 milestone Aug 26, 2021
@JuanCRdrums
Copy link

In the first link everything worked fine: Everything that was written in the text input appeared in the alert. However, when testing with the Google keyboard on the second link, the alert is not always displayed. With other keyboards it works fine, but not with the Google keyboard.

@reencafesas
Copy link
Author

reencafesas commented Sep 14, 2021

Hi,

Thanks a lot for the gifs! But, It is quite difficult for me to replicate this problem. That's why I prepared two different codesandbox links for you.

  1. https://codesandbox.io/s/distracted-silence-7zcn0?file=/index.html What are the outputs for both keyboards?
  2. https://codesandbox.io/s/crazy-allen-2jvuc?file=/src/DropdownDemo.vue Please see Dropdown.computed.visibleOptions method in main.js. Could you please debug it? What is the this.filterValue?

Best Regards,

Carefully debugging the google keyboard, it is identified that this one, unlike the other keyboards, enters the onFilterChange event but never enters the computed visibleOptions, the other keyboards first enter computed visibleOptions and then pass to onFilterChange, this is extremely serious 95% of devices have this keyboard and in all the error appears

@reencafesas
Copy link
Author

reencafesas commented Sep 27, 2021

Hi @mertsincan

a greeting, I have tried to modify the nuget package in the Dropdown.vue file but it has not been possible, however I have detected as a temporary solution to use the quasar dropdown and I started to review its behavior and you find this fragment

// Safari < 10.2 & UIWebView doesn't fire compositionend when
// switching focus before confirming composition choice
// this also fixes the issue where some browsers e.g. iOS Chrome
// fires "change" instead of "input" on autocomplete.
onChange: onComposition,
onKeydown: onTargetKeydown,
onKeyup: onTargetAutocomplete,
onKeypress: onTargetKeypress,
onFocus: selectInputText,

<input type="text" ref="filterInput" v-model="filterValue" @vnode-updated="onFilterUpdated" autoComplete="off" class="p-dropdown-filter p-inputtext p-component" :placeholder="filterPlaceholder" @keydown="onFilterKeyDown" @input="onFilterChange"/>

In primevue we have an @input event on line 24, is it possible to change this to an @change to mitigate the problem?

Thanks

juandfranco added a commit to juandfranco/primevue that referenced this issue Feb 18, 2022
juandfranco added a commit to juandfranco/primevue that referenced this issue Feb 21, 2022
@tugcekucukoglu tugcekucukoglu removed the Resolution: Cannot Replicate Issue could not be replicated by Core Team label Feb 25, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.12.1 milestone Feb 25, 2022
@tugcekucukoglu tugcekucukoglu changed the title Dropdown search dont work with gboard, This keyboard is brought by default android mobiles Dropdown search dont work with gboard Feb 25, 2022
@tugcekucukoglu tugcekucukoglu changed the title Dropdown search dont work with gboard Dropdown search don't work with Gboard Feb 25, 2022
tugcekucukoglu added a commit to tugcekucukoglu/primevue that referenced this issue Feb 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable
Projects
None yet
Development

No branches or pull requests

5 participants