Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Carousel swipe function is broken on iOS devices #1584

Closed
niclasd opened this issue Sep 22, 2021 · 1 comment
Closed

Carousel swipe function is broken on iOS devices #1584

niclasd opened this issue Sep 22, 2021 · 1 comment
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable
Milestone

Comments

@niclasd
Copy link

niclasd commented Sep 22, 2021

I'm submitting a bug report

Reason: the swipe function of the carousel on iOS touch devices does not work as expected

CodeSandbox Case

https://primefaces.org/primevue/showcase/#/carousel

Current behavior

Basic and vertical carousel:

  • You can swipe the first card, but with the second one, it just doesn't respond anymore.

Circular Carousel:

  • swiping in the lower region works

Expected behavior

Basic and vertical carousel:

  • All cards in Carousel are swipeable, not just the first one.

Circular carousel:

  • it should be possible to swipe over the entire area.

Minimal reproduction of the problem with instructions

Just visit the showcase with an iPhone/iPad and try it out.

https://primefaces.org/primevue/showcase/#/carousel

Screenshot affected area on circular carousel:
https://abload.de/img/2021-09-2211_51_06-pr79kz8.png

What is the motivation / use case for changing the behavior?

Please tell us about your environment:
iOS

  • Vue version: 3.X
    doesn't matter, bug is reproducable even on your demo showcase

  • PrimeVue version: 3.4.X
    doesn't matter, bug is reproducable even on your demo showcase

  • Browser: [all | Chrome XX | Firefox XX | IE XX | Safari XX | Mobile Chrome XX | Android X.X Web Browser | iOS XX Safari | iOS XX UIWebView | iOS XX WKWebView ]

iOS 14 & iOS 15 Safari

@cagataycivici cagataycivici added this to the 3.8.3 milestone Oct 25, 2021
@cagataycivici cagataycivici added the Type: Bug Issue contains a bug related to a specific component. Something about the component is not working label Oct 25, 2021
@TakCastel
Copy link

TakCastel commented Oct 28, 2021

Does it fix if we put e.stopPropagation() instead of e.preventDefault() inside Carousel.vue (line 268) ?

onTouchMove(e) {
  if (e.cancelable) {
    e.stopPropagation() // Change this
  }
},

TakCastel added a commit to TakCastel/primevue that referenced this issue Nov 2, 2021
@mertsincan mertsincan changed the title Bug: Carousel swipe function is broken on iOS devices (even reproducable on Primevue Showcase Page) Bug: Carousel swipe function is broken on iOS devices Nov 18, 2021
@mertsincan mertsincan changed the title Bug: Carousel swipe function is broken on iOS devices Carousel swipe function is broken on iOS devices Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working vue2-portable
Projects
None yet
Development

No branches or pull requests

5 participants