Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Red Color Palette #1944

Closed
julienripet opened this issue Jan 4, 2022 · 1 comment
Closed

Red Color Palette #1944

julienripet opened this issue Jan 4, 2022 · 1 comment
Assignees
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone

Comments

@julienripet
Copy link
Contributor

I'm submitting a ... (check one with "x")

[ ] bug report => Search github for a similar issue or PR before submitting
[ x] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

Could you please add actual reds to the basic Color Palette ?
I realise Pink is already in there, but it doesn't really cover all needs.

Here is what I added to my custom theme to have access to red css-variables, it might not be perfect, be it was good enough for my uses :

--red-50: #ffcdd2;
--red-100: #ef9a9a;
--red-200: #e57373;
--red-300: #ef5350;
--red-400: #f44336;
--red-500: #e53935;
--red-600: #d32f2f;
--red-700: #d50000;
--red-800: #c62828;
--red-900: #b71c1c;

I would've made a pull request directly to add them, but I'm unsure where it is handled

@tugcekucukoglu tugcekucukoglu added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 6, 2022
@FlipWarthog
Copy link
Contributor

FlipWarthog commented Jan 7, 2022

The color values themselves are set per theme.css and the specific set of options spans all 4 Prime libraries + PrimeFlex: https://www.primefaces.org/primeflex/theming

So I think having your own custom values to get you by is the best option for the short term.

@tugcekucukoglu tugcekucukoglu added this to the 3.12.1 milestone Feb 28, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Feb 28, 2022
tugcekucukoglu added a commit to tugcekucukoglu/primevue that referenced this issue Feb 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Development

No branches or pull requests

3 participants