Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] DataTable column reorder in wrong order #2225

Closed
nclemeur opened this issue Mar 1, 2022 · 0 comments
Closed

[BUG] DataTable column reorder in wrong order #2225

nclemeur opened this issue Mar 1, 2022 · 0 comments
Assignees
@tugcekucukoglu
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.13.0

Comments

@nclemeur
Copy link

nclemeur commented Mar 1, 2022 

[x ] bug report => Search github for a similar issue or PR before submitting

CodeSandbox Case (Bug Reports)

https://www.primefaces.org/primevue/#/datatable/reorder

Current behavior
If you drag a column header, it will always reorder the dragged column BEFORE the column drop target.
Expected behavior
It should reorder before the drop target only when the mouse is closer to the left border than right border in the drop target

Minimal reproduction of the problem with instructions
Please see animation illustrating the problem. In the scenario of the screencast, you would have expected the column order to be : Category, Name, Code Quantity not Name, Category, Code, Quantity as the Name column was dropped between Category and Code.

What is the motivation / use case for changing the behavior?

Fixing the bug

PrimeVUE.Mozilla.Firefox.2022-03-01.11-03-37.mp4
nclemeur pushed a commit to nclemeur/primevue that referenced this issue Mar 1, 2022
@nclemeur-daesim
Fixing primefaces#2225
b910dc5
@nclemeur nclemeur mentioned this issue Mar 1, 2022
Closed
@tugcekucukoglu tugcekucukoglu added the Status: Discussion Issue or pull request needs to be discussed by Core Team label Mar 1, 2022
@tugcekucukoglu tugcekucukoglu changed the title [BUG] Datatable column reorder in wrong order [BUG] DataTable column reorder in wrong order Jun 2, 2022
tugcekucukoglu added a commit to tugcekucukoglu/primevue that referenced this issue Jun 2, 2022
@tugcekucukoglu
Refactor primefaces#2225
855d63a
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Discussion Issue or pull request needs to be discussed by Core Team labels Jun 2, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.13.0 milestone Jun 2, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this Jun 2, 2022
tugcekucukoglu added a commit that referenced this issue Jun 2, 2022
@tugcekucukoglu
Merge pull request #2614 from tugcekucukoglu/data-drag-drop
66e9045 
Fixed #2225 - [BUG] DataTable column reorder in wrong order
@nclemeur nclemeur mentioned this issue Aug 10, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.13.0
Development

No branches or pull requests
2 participants
@nclemeur @tugcekucukoglu