Menu | disabled property as a function is not working with command prop

[marlonrichert]

Bug report

CodeSandbox Case

https://codesandbox.io/s/falling-cdn-8rlxcu?file=/src/MenuDemo.vue

Current behavior

In the menu model, if an object's disabled property is set to a function, then the corresponding Menu item's command no longer fires when clicked.

Expected behavior

According to the menu model documentation, disabled is allowed to be a boolean or a function returning a boolean.

Minimal reproduction of the problem with instructions

In the sandbox above, note that clicking Update does nothing, even though it has a valid command.

What is the motivation / use case for changing the behavior?

The implementation should match the documentation.

Environment

• Vue 3.1.5
• PrimeVue 3.12.2
• All browsers

[tugcekucukoglu]

This is expected behavior. Anchor link is disabled so click event do nothing.

[marlonrichert]

@tugcekucukoglu

This is expected behavior.

It’s not expected behavior according to your documentation:

Name	Type
disabled	boolean/function

Anchor link is disabled so click event do nothing.

That’s not at all an accurate description of the bug’s cause. The real problem lies on this line:

primevue/src/components/menu/Menu.vue

Line 88 in 6f48ac5

if (item.disabled) {

It does not check if disabled is a function. According to your own documentation, disabled is allowed to be a function, just like visible. It should be checked in the same way that you check visible:

primevue/src/components/menu/Menu.vue

Line 195 in 6f48ac5

return (typeof item.visible === 'function' ? item.visible() : item.visible !== false);

[AndreasNasman]

@tugcekucukoglu The disable property is not working per the documentation.

In the example, @marlonrichert has set the disable property to a function returning false,

disabled: () => false,

meaning the Menu component should be enabled. In the current implementation, it's disabled, however. See Marlon's answer where it occurs in the source code.

Either the documentation should be fixed, or better, the code be fixed to handle the function case