Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing invalid float label color #2510

Closed
gabjauf opened this issue Apr 28, 2022 · 0 comments
Closed

Missing invalid float label color #2510

gabjauf opened this issue Apr 28, 2022 · 0 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@gabjauf
Copy link

gabjauf commented Apr 28, 2022

I'm submitting a ... (check one with "x")

[x] bug report => Search github for a similar issue or PR before submitting
[ ] feature request => Please check if request is not on the roadmap already https://github.com/primefaces/primevue/wiki/Roadmap
[ ] support request => Please do not submit support request here, instead see http://forum.primefaces.org/viewforum.php?f=110

CodeSandbox Case (Bug Reports)
https://codesandbox.io/s/kppoii

Current behavior

When submitting directly the form, the p-error class is rightfully set on the floating labels but it does not set the label's color to red.

Expected behavior
The floating label should turn red.

Minimal reproduction of the problem with instructions

  • Open Sandbox
  • Submit form
  • Vue version: 3.X
  • PrimeVue version: 3.12.X
  • Browser: [all]

Notes
This is due to selector specificity: .p-float-label>label wins against .p-error
Two ways I see to solve it:

  • Make .p-float-label>label less specific
  • Make .p-error color !important
  • Make .p-error more specific (for example by associating it to .p-float-label)
@tugcekucukoglu tugcekucukoglu added the Status: Pending Review Issue or pull request is being reviewed by Core Team label May 16, 2022
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Pending Review Issue or pull request is being reviewed by Core Team labels May 24, 2022
@tugcekucukoglu tugcekucukoglu added this to the 3.12.7 milestone May 24, 2022
@tugcekucukoglu tugcekucukoglu self-assigned this May 24, 2022
@tugcekucukoglu tugcekucukoglu changed the title .p-error does not set red color on floating form labels Missing invalid float label color May 24, 2022
tugcekucukoglu added a commit that referenced this issue May 24, 2022
Fixed #2510 - Missing invalid float label color
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants