Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DataTable: Selection and Row/Cell editing : Cannot input space character #4120

Closed
NikoGJ opened this issue Jul 10, 2023 · 3 comments · Fixed by #4333
Closed

DataTable: Selection and Row/Cell editing : Cannot input space character #4120

NikoGJ opened this issue Jul 10, 2023 · 3 comments · Fixed by #4333
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.34.0

Comments

@NikoGJ
Copy link
Contributor

NikoGJ commented Jul 10, 2023

Describe the bug

When a datatable uses selection mode single or multiple and cell or row editing, we cannot input space character in the InputText anymore.

Reproducer

https://codesandbox.io/p/sandbox/loving-noyce-yxnmvh?file=%2Fsrc%2FApp.vue%3A13%2C37

PrimeVue version

3.29.0

Vue version

3.x

Language

ALL

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Check the codesandbox
Try input data with some space characters in both datatables.
Notice that only the datatable with no selection works with space characters.

Expected behavior

It should be possible to input space characters in InputText in all scenarios.
@NikoGJ NikoGJ added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 10, 2023
@limbitskiy
Copy link

yes, i have the same problem

NikoGJ added a commit to NikoGJ/primevue that referenced this issue Aug 20, 2023
@NikoGJ
primefaces#4120 Datatable: Allow input of space character in editor w…
01f40f5 
…hen Datatable has row selection + row edit features enabled
@NikoGJ NikoGJ mentioned this issue Aug 22, 2023
Closed
NikoGJ added a commit to NikoGJ/primevue that referenced this issue Aug 27, 2023
@NikoGJ
Fixed primefaces#4120 - DataTable: Selection and Row/Cell editing : C…
6b269ca 
…annot input space character
@NikoGJ NikoGJ mentioned this issue Aug 27, 2023
Merged
@mertsincan mertsincan added this to the 3.33.1 milestone Sep 5, 2023
@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Sep 5, 2023
mertsincan pushed a commit that referenced this issue Sep 5, 2023
@NikoGJ
Fixed #4120 - DataTable: Selection and Row/Cell editing : Cannot inpu…
88ac7e2 
…t space character (#4333)

* Fixed #4120 - DataTable: Selection and Row/Cell editing : Cannot input space character

* Fixed #4337 - DataTable: editingRows is not reactive
@MarcM-PL
Copy link

I updated to 3.34.1 today and I still see this issue, is there anything else I need to do?

@NikoGJ
Copy link
Contributor Author

NikoGJ commented Sep 30, 2023 •
edited

@MarcM-PL Tested with the original reproducer of the ticket, but in 3.35.0 and I don't see the issue anymore.
Could you share a repo sand box with your scenario ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.34.0
4 participants
@mertsincan @NikoGJ @MarcM-PL @limbitskiy