Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FileUpload: Class .p-fileupload-highlight is missing #4129

Closed
SoyDiego opened this issue Jul 12, 2023 · 1 comment · Fixed by #4130
Closed

FileUpload: Class .p-fileupload-highlight is missing #4129

SoyDiego opened this issue Jul 12, 2023 · 1 comment · Fixed by #4130
Assignees
@tugcekucukoglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.32.1

Comments

@SoyDiego
Copy link
Contributor

Describe the bug

The class .p-fileupload-highlight is added when drag over a file in the component but nothing is happening because the styles are not in the css file.

PROBLEM

problem fileupload primevue

Reproducer

https://primevue.org/fileupload/

PrimeVue version

3.30.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

Show the highlight when you are over the component
@SoyDiego SoyDiego added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 12, 2023
@SoyDiego SoyDiego mentioned this issue Jul 12, 2023
Merged
@tugcekucukoglu tugcekucukoglu self-assigned this Jul 13, 2023
@SoyDiego
Copy link
Contributor Author

Hi @tugcekucukoglu, this issue can be fixed with this PR #4130 and this primefaces/primevue-sass-theme#14. Both are necessary :)

@mertsincan mertsincan added this to the 3.32.1 milestone Aug 18, 2023
@mertsincan mertsincan added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 18, 2023
tugcekucukoglu added a commit that referenced this issue Aug 18, 2023
@tugcekucukoglu
Refactor #4129
d50ebae
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.32.1
Development

Successfully merging a pull request may close this issue.

Added .p-fileupload-highlight class SoyDiego/primevue
3 participants
@mertsincan @SoyDiego @tugcekucukoglu