Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calendar: increment minute #4207

Closed
freddroguest opened this issue Jul 25, 2023 · 1 comment · Fixed by #4208
Closed

Calendar: increment minute #4207

freddroguest opened this issue Jul 25, 2023 · 1 comment · Fixed by #4208
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.32.1

Comments

@freddroguest
Copy link
Contributor

Describe the bug

When your set a step-minute on a timeOnly Calendar it's not working.

I pulled the projet and see that it tries to add a number (this.currentMinute) and a string (this.stepMinute).

Reproducer

https://codesandbox.io/p/sandbox/primevue-demo-forked-t6wlzx?file=%2Fsrc%2FApp.vue%3A3%2C1

PrimeVue version

3.31.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

Bug occurs on increment value only.

Expected behavior

No response
@freddroguest freddroguest added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Jul 25, 2023
freddroguest pushed a commit to freddroguest/primevue that referenced this issue Jul 25, 2023
Convert stepMinute / hour / second to Number
da28c69 
primefaces#4207
@freddroguest freddroguest mentioned this issue Jul 25, 2023
Merged
@freddroguest
Copy link
Contributor Author

It occurs only when you pass a string as value, but no casting is applied.

@mertsincan mertsincan added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 18, 2023
@mertsincan mertsincan added this to the 3.32.1 milestone Aug 18, 2023
@mertsincan mertsincan linked a pull request Aug 18, 2023 that will close this issue
Convert stepMinute / hour / second to Number #4208
Merged
mertsincan pushed a commit that referenced this issue Aug 18, 2023
@freddroguest
Convert stepMinute / hour / second to Number (#4208)
2c1e30b 
#4207

Co-authored-by: VacataireG2V <fdroguest@g2vservices.fr>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.32.1
Development

Successfully merging a pull request may close this issue.

Convert stepMinute / hour / second to Number freddroguest/primevue
2 participants
@mertsincan @freddroguest