Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sidebar: using unstyled mode and Tailwind theme, the :modal="false" doesn't work. Can't disable the modal layer. #4288

Closed
daniel-cintra opened this issue Aug 17, 2023 · 2 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@daniel-cintra
Copy link

Describe the bug

In a clean install of PrimeVue, using unstyled mode with the Tailwind theme, for the Sidebar component, the :modal="false" is ignored. It behaves like the prop is always :modal="true".

Reproducer

PrimeVue version

3.32.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

In a clean PrimeVue install (with Tailwind):

<template>
  <div class="card flex justify-content-center">
    <Sidebar v-model:visible="visible" :modal="false">
      <h2>Sidebar</h2>
      <p>
        Lorem ipsum dolor sit amet, consectetur adipiscing elit, sed do eiusmod tempor incididunt ut
        labore et dolore magna aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco
        laboris nisi ut aliquip ex ea commodo consequat.
      </p>
    </Sidebar>
    <Button label="Sidebar Toggle" @click="visible = true" />
  </div>
</template>

<script setup>
import { ref } from 'vue'
import Sidebar from 'primevue/sidebar'
import Button from 'primevue/button'

const visible = ref(false)
</script>

Expected behavior

No response

@daniel-cintra daniel-cintra added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 17, 2023
@atakantepe atakantepe self-assigned this Aug 18, 2023
@atakantepe atakantepe added this to the 3.32.1 milestone Aug 18, 2023
@atakantepe atakantepe added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 18, 2023
atakantepe added a commit that referenced this issue Aug 18, 2023
…lse" doesn't work. Can't disable the modal layer. #4288
@daniel-cintra
Copy link
Author

The 3.32.1 update, fixed the modal/backdrop opacity (now it's visually removed as expected). But the content area outside the Sidebar using prop :modal="false" isn't accessible (in unstyled mode with Tailwind theme) as the mask (that remains and is invisible), blocks all the page content.

Disabling unstyled mode, and using primevue/resources/themes/lara-light-indigo/theme.css everything works as expected (content outside Sidebar is accessible using prop :modal="false").

@AcidRaZor
Copy link

@atakantepe This appears to be still an issue, some guidance required

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

3 participants