Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataTable: PT Options missing for Expansion Row Cell #4306

Closed
kaipaysen opened this issue Aug 21, 2023 · 4 comments
Closed

DataTable: PT Options missing for Expansion Row Cell #4306

kaipaysen opened this issue Aug 21, 2023 · 4 comments
Assignees
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@kaipaysen
Copy link

kaipaysen commented Aug 21, 2023

Describe the bug

The td Element surrounding the expansion template is not accessible with the PassThrough API.
I guess that is related to
https://github.com/primefaces/primevue/blob/master/components/lib/datatable/TableBody.vue#L94-L96.

Reproducer

StackBlitz

PrimeVue version

3.32.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

Open StackBlitz and expand one of the rows in the table.

Expected behavior

I'd expect a red bottom border for the expanded row.

@kaipaysen kaipaysen added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Aug 21, 2023
@tugcekucukoglu
Copy link
Member

There is a misunderstanding here. td already has a pt. But expansion is a slot and it totally depends on how the user will use it. We can only export data and index. It may not be right for us to intervene from the outside, because we may not be able to guess correctly how the user plans templating.

@kaipaysen
Copy link
Author

kaipaysen commented Aug 21, 2023

@tugcekucukoglu please have a look at the following screenshots

  1. the td in the expansion row has no pc-section attribute.
    image

  2. compared to the td in body row which has a pc-section attribute.
    image

I'd like to work on the DOM Element td outside of the slot.

@tugcekucukoglu
Copy link
Member

Thanks for the screenshots. Is there any reproducer link for the issue?

https://primevue.org/datatable/#row_expansion
Screen Shot 2023-08-21 at 16 39 37

@tugcekucukoglu tugcekucukoglu self-assigned this Aug 21, 2023
@kaipaysen
Copy link
Author

kaipaysen commented Aug 21, 2023

Is there any reproducer link for the issue?

I used the example you mentioned from then website to create the screenshots.
If you expand the first row a second tr will be visible which holds the "to-be-pted" td.

EDIT: Reproducer
image

@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Aug 24, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.32.3 milestone Aug 24, 2023
tugcekucukoglu added a commit that referenced this issue Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

No branches or pull requests

2 participants