Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ptOptions property to all components #4384

Closed
mertsincan opened this issue Sep 4, 2023 · 3 comments
Closed

Add ptOptions property to all components #4384

mertsincan opened this issue Sep 4, 2023 · 3 comments
Assignees
Labels
Type: New Feature Issue contains a new feature or new component request
Milestone

Comments

@mertsincan
Copy link
Member

mertsincan commented Sep 4, 2023

Used to configure pass through options of the component.

:ptOptions="{ mergeSections: true, mergeProps: false }"
Similar to https://primevue.org/passthrough/#usepassthrough

@mertsincan mertsincan added the Type: New Feature Issue contains a new feature or new component request label Sep 4, 2023
@mertsincan mertsincan added this to the 3.33.1 milestone Sep 4, 2023
@mertsincan mertsincan self-assigned this Sep 4, 2023
@mertsincan mertsincan reopened this Sep 4, 2023
mertsincan added a commit that referenced this issue Sep 4, 2023
mertsincan added a commit that referenced this issue Sep 4, 2023
mertsincan added a commit that referenced this issue Sep 4, 2023
@mertsincan
Copy link
Member Author

Last commit: 91b27d7

mertsincan added a commit that referenced this issue Sep 5, 2023
@adiramardiani
Copy link

Hi @mertsincan @tugcekucukoglu
Yes I now on 3.34 has BC about mergeProps, but is the mergeProps option recursive to another sub class component ?
I write like this

<Menubar
      :pt-options="{ mergeProps: true }"
      :pt="{
        root: { class: 'some-class' },
        label: { class: 'some-class' },
        menu: {
          class: 'menu-for-ul-class'
        }
      }"
    >

But the render like this, not merge

<ul class="menu-for-ul-class" data-pc-section="menu" role="menubar" tabindex="0" >...</ul>

I write like this, but the render is same

<Menubar
      :pt-options="{ mergeProps: true }"
      :pt="{
        root: { class: 'some-class' },
        label: { class: 'some-class' },
        menu: {
          class: 'menu-for-ul-class',
          ptOptions: {
            mergeProps: true
          }
        }
      }"
    >

About menu pt in menubar I refer on this documentation MenuBar

@mertsincan
Copy link
Member Author

@adiramardiani I think this issue has already been fixed in the latest version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: New Feature Issue contains a new feature or new component request
Projects
None yet
Development

No branches or pull requests

2 participants