Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column: headercheckboxicon slot not working #4543

Closed
pcoterecollective opened this issue Oct 3, 2023 · 0 comments · Fixed by #4544
Closed

Column: headercheckboxicon slot not working #4543

pcoterecollective opened this issue Oct 3, 2023 · 0 comments · Fixed by #4544
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@pcoterecollective
Copy link

pcoterecollective commented Oct 3, 2023

Describe the bug

Context:
Usage in DataTable component;

Bug:
Using the headercheckboxicon slot doesn't overwrite the header checkbox fallback icon.

Reproducer

https://codesandbox.io/p/sandbox/objective-morning-8yk4w3

PrimeVue version

3.35.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

Version 117.0

Steps to reproduce the behavior

  • Create a view with a DataTable component in it;
  • Add a Column component in it and set its selection-mode attribute to "multiple";
  • Use the columns headercheckboxicon slot to replace the "select all" checkbox icon;
  • Use the columns rowcheckboxicon slot to replace rows checkbox icon;
  • Add a Column for any other field you need (though this is not the point);

Though the rowcheckboxicon seems to work as expected, the "select all" checkbox fallback icon isn't being replaced with headercheckboxicon slot's content.

Expected behavior

Content passed through the headercheckboxicon slot should replace checkbox fallback icon.

@pcoterecollective pcoterecollective added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 3, 2023
FlipWarthog added a commit to FlipWarthog/primevue that referenced this issue Oct 3, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 4, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.35.1 milestone Oct 4, 2023
tugcekucukoglu added a commit that referenced this issue Oct 4, 2023
Fix #4543: Column: headercheckboxicon slot not working
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants