Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation: PT Options not showing in any component on the web docs. #4601

Closed
jorgemunozc opened this issue Oct 12, 2023 · 0 comments
Closed

Documentation: PT Options not showing in any component on the web docs. #4601

jorgemunozc opened this issue Oct 12, 2023 · 0 comments
Labels
Component: Documentation Issue or pull request is related to Documentation

Comments

@jorgemunozc
Copy link
Contributor

jorgemunozc commented Oct 12, 2023 •
edited
Loading

Describe the bug

In the documentation of the components's "Pass through" tab, PT Options are not showing up.

After some digging I found that this code in components/doc/DocApiTable.vue was the issue:
<span v-if="v?.includes('<a')" :id="id + '.' + k" class="doc-option-description" v-html="v"> </span>
An alternative to fix the bug would be checking that v is a string:
<span v-if="typeof v === 'string' && v?.includes('<a')" :id="id + '.' + k" class="doc-option-description" v-html="v"> </span>

Reproducer

https://primevue.org/checkbox/#pt.doc.checkbox

PrimeVue version

3.36.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@jorgemunozc jorgemunozc added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 12, 2023
@jorgemunozc jorgemunozc changed the title Documentation: PT Options not showing in any component Documentation: PT Options not showing in any component on the web docs. Oct 12, 2023
jorgemunozc added a commit to jorgemunozc/primevue that referenced this issue Oct 12, 2023
@jorgemunozc
Fix issue primefaces#4601
4f9691b
jorgemunozc added a commit to jorgemunozc/primevue that referenced this issue Oct 12, 2023
@jorgemunozc
Fix issue primefaces#4601
082f513
@jorgemunozc jorgemunozc mentioned this issue Oct 12, 2023
Merged
tugcekucukoglu added a commit that referenced this issue Oct 13, 2023
@tugcekucukoglu
Merge pull request #4602 from jorgemunozc/master
38140b5 
Fix issue #4601 - Passthrough options for components not showing in web documentation
@tugcekucukoglu tugcekucukoglu added Component: Documentation Issue or pull request is related to Documentation and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Component: Documentation Issue or pull request is related to Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jorgemunozc @tugcekucukoglu