Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overlaypanel: Overlay panel doesnot close on escape button click #4620

Closed
akshayaqburst opened this issue Oct 15, 2023 · 0 comments · Fixed by #4621
Closed

Overlaypanel: Overlay panel doesnot close on escape button click #4620

akshayaqburst opened this issue Oct 15, 2023 · 0 comments · Fixed by #4621
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.37.0

Comments

@akshayaqburst
Copy link
Contributor

Describe the bug

Overlaypanel: Overlay panel doesnot close on escape button click

Reproducer

https://primevue.org/overlaypanel/

PrimeVue version

3.36

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. Go to Overlay panel
  2. Click on Show button, an overlay pops up.
  3. Click on escape key.

Expected behavior

Overlay should close on escape key press.
@akshayaqburst akshayaqburst added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 15, 2023
akshayantony55 added a commit to qburst/primevue_qb_1 that referenced this issue Oct 15, 2023
@akshayantony55
fix primefaces#4620 Overlaypanel: Overlay panel doesnot close on esca…
02cbc1e 
…pe button click
@akshayaqburst akshayaqburst mentioned this issue Oct 15, 2023
Merged
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Oct 17, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.37.0 milestone Oct 17, 2023
tugcekucukoglu added a commit that referenced this issue Oct 17, 2023
@tugcekucukoglu
Merge pull request #4621 from qburst/master
366f136 
fix #4620 Overlaypanel: Overlay panel doesnot close on escape button click
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.37.0
Development

Successfully merging a pull request may close this issue.

fix #4620 Overlaypanel: Overlay panel doesnot close on escape button click qburst/primevue_qb_1
2 participants
@tugcekucukoglu @akshayaqburst