Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Component Styles: Remove use of !important now that @layer is used #4637

Closed
FlipWarthog opened this issue Oct 17, 2023 · 0 comments · Fixed by #4638
Closed

Component Styles: Remove use of !important now that @layer is used #4637

FlipWarthog opened this issue Oct 17, 2023 · 0 comments · Fixed by #4638
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.45.0

Comments

@FlipWarthog
Copy link
Contributor

Describe the bug

Copy of: primefaces/primereact#5096

See this guide for more detailed info, but with the use of @layer in the component CSS, any use of !important now has a bunch of extra weight to it, because of how !important is resolved. The below sample shows a basic example a user saw where they expected their app style to override the lib style, which it didn't. So they needed to resort to adding their own @layer primevue to resolve the conflict.

https://stackblitz.com/edit/jwh1eh?file=src%2FApp.vue,src%2Fstyle.css

Reproducer

https://stackblitz.com/edit/jwh1eh?file=src%2FApp.vue,src%2Fstyle.css

PrimeVue version

3.36.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

No response
@FlipWarthog FlipWarthog added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Oct 17, 2023
@FlipWarthog FlipWarthog mentioned this issue Oct 17, 2023
Merged
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Dec 21, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.45.0 milestone Dec 21, 2023
tugcekucukoglu added a commit that referenced this issue Dec 21, 2023
@tugcekucukoglu
Merge pull request #4638 from FlipWarthog/no-important
84f735e 
Fix #4637 - Component Styles: Remove use of !important now that @layer is used
tugcekucukoglu added a commit that referenced this issue Dec 21, 2023
@tugcekucukoglu
Refactor #4637
23676e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.45.0
Development

Successfully merging a pull request may close this issue.

Fix #4637 - Component Styles: Remove use of !important now that @layer is used FlipWarthog/primevue
2 participants
@tugcekucukoglu @FlipWarthog