Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PanelMenu: Menu items with no sub-items toggling border radius #4816

Closed
XanEliot opened this issue Nov 14, 2023 · 0 comments · Fixed by #4844
Closed

PanelMenu: Menu items with no sub-items toggling border radius #4816

XanEliot opened this issue Nov 14, 2023 · 0 comments · Fixed by #4844
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone

Comments

@XanEliot
Copy link

Describe the bug

In our program we are using PanelMenu for a side bar navigation component. We require some items to have sub-items but most are standalone. I would expect the border radius of the standalone items to remain the same, but the bottom radius becomes 0 as if the item were expanding.

An example within the PanelMenu documentation:
https://primevue.org/panelmenu/#command
You can see the behavior by clicking on the "Sign Out" button multiple times. Every time it is clicked the bottom border toggles.

Reproducer

https://codesandbox.io/p/sandbox/condescending-silence-7gyyrt

PrimeVue version

3.28.0

Vue version

3.x

Language

TypeScript

Build / Runtime

Vue CLI App

Browser(s)

No response

Steps to reproduce the behavior

  1. Click the "No Sub Items" item. It's border radius becomes 0.
  2. Click the item again. It toggles back to the original state

Expected behavior

The border radius should remain unchanged when an item without sub-items is selected

@XanEliot XanEliot added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 14, 2023
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working Component: Theme Issue or pull request is related to Theme Component: Unstyled Issue or pull request is related to unstyled mode and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible Component: Theme Issue or pull request is related to Theme labels Nov 15, 2023
xiaodong2008 added a commit to xiaodong2008/primevue that referenced this issue Nov 19, 2023
@tugcekucukoglu tugcekucukoglu removed the Component: Unstyled Issue or pull request is related to unstyled mode label Nov 21, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.42.0 milestone Nov 21, 2023
tugcekucukoglu added a commit that referenced this issue Nov 21, 2023
Fix #4816: Menu items with no sub-items toggling border radius
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants