Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tree: Slot for icon property of value #4833

Closed
ig-onoffice-de opened this issue Nov 16, 2023 · 0 comments · Fixed by #5339
Closed

Tree: Slot for icon property of value #4833

ig-onoffice-de opened this issue Nov 16, 2023 · 0 comments · Fixed by #5339
Assignees
@tugcekucukoglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.50.0

Comments

@ig-onoffice-de
Copy link
Contributor

ig-onoffice-de commented Nov 16, 2023 •
edited
Loading

Describe the bug

There is no slot for the icon property of the tree value, but we need one to use the FontAwesomeIcon component.
Otherwise, we have to import all the whole css-file which is really large.

See also discussion

Reproducer

link

PrimeVue version

3.40.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

No response

Expected behavior

There is a slot for the treeNode icon.
@ig-onoffice-de ig-onoffice-de added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 16, 2023
ig-onoffice-de added a commit to ig-onoffice-de/primevue that referenced this issue Feb 26, 2024
@ig-onoffice-de
feat: Tree - add slot for nodeIcon
d6d5855 
closes primefaces#4833
@ig-onoffice-de ig-onoffice-de mentioned this issue Feb 26, 2024
Merged
@tugcekucukoglu tugcekucukoglu added Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Mar 13, 2024
@tugcekucukoglu tugcekucukoglu added this to the 3.50.0 milestone Mar 13, 2024
@tugcekucukoglu tugcekucukoglu self-assigned this Mar 13, 2024
tugcekucukoglu added a commit that referenced this issue Mar 13, 2024
@tugcekucukoglu
Refactor #4833
dd9f38f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.50.0
Development

Successfully merging a pull request may close this issue.

feat(Tree): Add slot for nodeIcon ig-onoffice-de/primevue
2 participants
@tugcekucukoglu @ig-onoffice-de