Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Editor: Readonly prop does not react to any change #4872

Closed
kadirboylu opened this issue Nov 23, 2023 · 0 comments · Fixed by #4873
Closed

Editor: Readonly prop does not react to any change #4872

kadirboylu opened this issue Nov 23, 2023 · 0 comments · Fixed by #4873
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Milestone
3.42.0

Comments

@kadirboylu
Copy link
Contributor

Describe the bug

Readonly prop does not react to any change. When the editor is mounted, the prop is read and the editor is set to readonly or not. But when the prop changes, the editor does not react to it.

Reproducer

https://stackblitz.com/edit/editor-readonly-bug

PrimeVue version

3.41.1

Vue version

3.x

Language

TypeScript

Build / Runtime

Vite

Browser(s)

No response

Steps to reproduce the behavior

  1. Create an editor with a readonly prop
  2. Change the prop
  3. The editor does not react to the change

Expected behavior

The editor should react to the change of the prop and set the editor to readonly or not.
@kadirboylu kadirboylu added the Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible label Nov 23, 2023
@kadirboylu kadirboylu mentioned this issue Nov 23, 2023
Merged
tugcekucukoglu added a commit that referenced this issue Nov 24, 2023
@tugcekucukoglu
Merge pull request #4873 from kadirboylu/master
4b322a7 
Fix #4872: Editor's readonly prop does not react to any changes
@tugcekucukoglu tugcekucukoglu added Type: Bug Issue contains a bug related to a specific component. Something about the component is not working and removed Status: Needs Triage Issue will be reviewed by Core Team and a relevant label will be added as soon as possible labels Nov 24, 2023
@tugcekucukoglu tugcekucukoglu added this to the 3.42.0 milestone Nov 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Type: Bug Issue contains a bug related to a specific component. Something about the component is not working
Projects
None yet
Milestone
3.42.0
Development

Successfully merging a pull request may close this issue.

Fix #4872: Editor's readonly prop does not react to any changes kadirboylu/primevue
2 participants
@tugcekucukoglu @kadirboylu