Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New invalid and variant properties #5176

Closed
21 tasks done
tugcekucukoglu opened this issue Jan 30, 2024 · 2 comments
Closed
21 tasks done

New invalid and variant properties #5176

tugcekucukoglu opened this issue Jan 30, 2024 · 2 comments
Assignees
@tugcekucukoglu
Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Milestone
3.48.0

Comments

@tugcekucukoglu
Copy link
Member

tugcekucukoglu commented Jan 30, 2024 •
edited

  • invalid: "false" | "true"
  • variant: "outline" | "filled"

Components;

  • AutoComplete
  • Calendar
  • CascadeSelect
  • Checkbox
  • Chips
  • Dropdown
  • InputMask
  • InputNumber
  • InputSwitch
  • InputText
  • Listbox
  • MultiSelect
  • Password
  • RadioButton
  • SelectButton
  • Textarea
  • ToggleButton
  • TreeSelect
  • TriStateCheckbox
@tugcekucukoglu tugcekucukoglu added this to the 3.48.0 milestone Jan 30, 2024
@tugcekucukoglu tugcekucukoglu added the Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add label Jan 30, 2024
tugcekucukoglu added a commit that referenced this issue Jan 30, 2024
@tugcekucukoglu
Refactor #5176 - invalid property added
a9a2549
@tugcekucukoglu tugcekucukoglu self-assigned this Jan 31, 2024
@tugcekucukoglu tugcekucukoglu mentioned this issue Jan 31, 2024
Closed
tugcekucukoglu added a commit that referenced this issue Feb 2, 2024
@tugcekucukoglu
Refactor #5176
45a23e9
tugcekucukoglu added a commit that referenced this issue Feb 2, 2024
@tugcekucukoglu
Refactor #5176
90cd9e2
@SamuelWei
Copy link

@tugcekucukoglu What about adding aria-invalid attribute if the new prop invalid is true ? This would save writing a lot of code.

@tugcekucukoglu
Copy link
Member Author

Thanks for your interest! I can add it to the next version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tugcekucukoglu tugcekucukoglu

Labels
Type: Enhancement Issue contains an enhancement related to a specific component. Additional functionality has been add
Projects
None yet
Milestone
3.48.0
Development

No branches or pull requests
2 participants
@SamuelWei @tugcekucukoglu